Add folding functionality to dollies #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we see the icon difference first? |
java_X4zIOX2kzc.mp4 |
OneEyeMaker
requested changes
Sep 7, 2023
src/main/java/mcp/mobius/betterbarrels/common/items/dolly/ItemBarrelMover.java
Outdated
Show resolved
Hide resolved
src/main/java/mcp/mobius/betterbarrels/common/items/dolly/ItemBarrelMover.java
Outdated
Show resolved
Hide resolved
src/main/java/mcp/mobius/betterbarrels/common/items/dolly/ItemBarrelMover.java
Outdated
Show resolved
Hide resolved
OneEyeMaker
approved these changes
Sep 8, 2023
|
can this be a config option? i need the newest version of jabba for angelica null safety but i don't like the folding functionality as i think it's too strong to be able to carry that many dollies while adventuring. could this please be a config option? |
|
JABBA's on passive -- if you or someone else want to submit a PR go for it, or if you find a dev that cares, similar. Otherwise not likely |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regular, empty dollies (not diamond) can now be folded by sneak-right-clicking while not aiming at a valid, carryable inventory. Folded dollies can't pick up containers, but they stack and can be put into backpacks.
Also promotes jimbno's uutex icons for dollies to the main repository.
Marking this PR as draft due to the feature freeze, but it's functionally complete and can be merged after the freeze is lifted.